Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/standardized billing line item model #77

Merged
merged 28 commits into from
Aug 14, 2024

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Jun 17, 2024

PR Overview

This PR will address the following Issue/Feature: Internal Project

This PR will result in the following new package version: v0.12.0

While this release shouldn't cause any breaking changes, we should include it in a minor (v0.X.0) release as it includes two new staging models.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Feature Updates

  • Addition of the following new staging models and accompanying upstream references:
    • stg_stripe__discount (required for downstream dbt_stripe model transformations)
    • stg_stripe__product (enabled by default, but can be disabled by setting the stripe__using_subscriptions variable to false)

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • [n/a] The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Confirmed new staging models are materializing as expected regardless of the variables configurations.

If you had to summarize this PR in an emoji, which would it be?

💬

Copy link

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for release!

@fivetran-reneeli fivetran-reneeli merged commit 8e30f10 into main Aug 14, 2024
7 checks passed
@fivetran-reneeli fivetran-reneeli deleted the feature/standardized-billing-line-item-model branch August 14, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants