-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/v2 updates #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie thanks for this PR! There definitely was a lot added to this package, thanks for working though all of these updates! 🙌
The PR looks great, I just had a few inline comments to be addressed as well as a few thoughts I would like your insight on before approving. See inline comments for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie updates look great!! Only request is to move the disabling docs to the required section of the README opposed to the additional.
Once we make that update we will be good to hold this PR until all others are ready to merge.
@fivetran-jamie one last thing I noticed was that the date_day field for the reports seemed to report on different hours each day. Is this regular? I would imagine the date_day field to simple display the date and not an hour of the day? |
good catch -- yeah i think date_trunc'ing |
…twitter_source into feature/v2-updates
seeds
Feature/v2 updates
Pull Request
Are you a current Fivetran customer?
fivetran made PR
What change(s) does this PR introduce?
tweet
table as wellidentifier
variablesDid you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🍏
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.