Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/v2 updates #13

Merged
merged 34 commits into from
Sep 1, 2022
Merged

Feature/v2 updates #13

merged 34 commits into from
Sep 1, 2022

Conversation

fivetran-jamie
Copy link
Contributor

Pull Request
Are you a current Fivetran customer?

fivetran made PR

What change(s) does this PR introduce?

  • adds line item, campaign, and account report tables
  • adds tweet table as well
  • incorporates passthrough columns into report tables
  • adds schema tests to all staging models
  • aligns promoted_tweet_report model with the other report models
  • updates README
  • documents new tables and columns
  • incorporate identifier variables
  • TODO AFTER APPROVING: regen docs

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature [link bug/feature number here]
  • No

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🍏

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 29, 2022
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie thanks for this PR! There definitely was a lot added to this package, thanks for working though all of these updates! 🙌

The PR looks great, I just had a few inline comments to be addressed as well as a few thoughts I would like your insight on before approving. See inline comments for more details.

macros/staging_columns.sql Outdated Show resolved Hide resolved
packages.yml Outdated Show resolved Hide resolved
models/src_twitter_ads.yml Show resolved Hide resolved
models/src_twitter_ads.yml Show resolved Hide resolved
models/stg_twitter_ads.yml Show resolved Hide resolved
dbt_project.yml Show resolved Hide resolved
models/src_twitter_ads.yml Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie updates look great!! Only request is to move the disabling docs to the required section of the README opposed to the additional.

Once we make that update we will be good to hold this PR until all others are ready to merge.

@fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-jamie one last thing I noticed was that the date_day field for the reports seemed to report on different hours each day. Is this regular? I would imagine the date_day field to simple display the date and not an hour of the day?

@fivetran-jamie
Copy link
Contributor Author

@fivetran-jamie one last thing I noticed was that the date_day field for the reports seemed to report on different hours each day. Is this regular? I would imagine the date_day field to simple display the date and not an hour of the day?

good catch -- yeah i think date_trunc'ing date_day in the staging models is the best move

@fivetran-sheringuyen fivetran-sheringuyen merged commit 0cc59b9 into main Sep 1, 2022
johnf pushed a commit to johnf/dbt_twitter_source that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants