Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package packages.yml name #18

Merged

Conversation

johnf
Copy link
Contributor

@johnf johnf commented Nov 28, 2022

Are you a current Fivetran customer?
John Ferlito, Co-Founder, Gladly

What change(s) does this PR introduce?
Use the new package name

Did you update the CHANGELOG?

  • No, not releaserelated

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • No, doesn't need a release

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature [link bug/feature number here]
  • No

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

Tested by editing packages.yml on my repository

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood
🐹

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johnf thanks so much for opening this PR to address this documentation bug.

While you are correct that this is just a documentation fix, we will still need to bump the version and cut a release for this fix in order for the dbt hub to capture the changes.

As such, would you be able to bump the version within the dbt_project.yml and the integration_tests/dbt_project.yml files. Finally, would you be able to add release notes within the CHANGELOG. Don't forget to add yourself as a contributor!

Once you apply those small updates, I will be able to merge these changes and cut a release! Let me know if you have any questions and thanks again for taking the time to open this PR 😄

Use the new package name
@johnf
Copy link
Contributor Author

johnf commented Nov 28, 2022

@fivetran-joemarkiewicz Thanks, done.

@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the base branch from main to bugfix/keyword-id-addition November 30, 2022 15:48
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnf thanks so much for applying the updates to the package!

Coincidentally, I am rolling some patch updates into the package as we speak within PR #17. As such, I will fold your changes into that PR and merge them all together into main.

We really appreciate your eagle eyes and helping to improve our package documentation. It is community contributors like yourself that truly help to keep these packages improving over time!

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 7e930dd into fivetran:bugfix/keyword-id-addition Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants