Update dbt dependencies #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
requested changes
Sep 22, 2023
CHANGELOG.md
Outdated
| @@ -1,3 +1,9 @@ | |||
| # dbt_zendesk v0.12.0 | |||
| This PR updates the `dbt-date` version to the most current, [">=0.9.0", "<0.10.0"]. | |||
There was a problem hiding this comment.
Shouldn't this be in it's own ## Updates section?
There was a problem hiding this comment.
true, updated
CHANGELOG.md
Outdated
Comment on lines
4
to
5
| ## Rollback | ||
| This [PR #110](https://github.com/fivetran/dbt_zendesk/pull/110/files) is a rollback to v0.10.2. We are seeing issues in business minutes and SLA duplicate records following the v0.11.0 release. |
There was a problem hiding this comment.
Is this intended to be here?
There was a problem hiding this comment.
whoops-- removed
fivetran-joemarkiewicz
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
One final comment regarding the wording of the CHANGELOG. With that, this is good to go.
Let's plan to fold this change into the other Zendesk changes that are taking place at the moment. As well as holding off on releasing until other dbt-date and expecations updates are ready in other packages.
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
fivetran-joemarkiewicz
changed the base branch from
main
to
bugfix/duplicate_sla_event_ids
fivetran-joemarkiewicz
requested changes
Oct 4, 2023
…fivetran/dbt_zendesk into feature/update_dbt_dependencies
fivetran-reneeli
merged commit 9c4d99e
into
bugfix/duplicate_sla_event_ids
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: #109
This PR will result in the following new package version: v0.12.0
Will require a full refresh to update the logic coming from dbt-date
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Updates the dbt-date dependency version to the most current
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Run with a full refresh
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
💃