Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/enable unstructured #173

Merged
merged 89 commits into from
Oct 10, 2024

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Oct 10, 2024

PR Overview

This PR will address the following Issue/Feature:

  • Internal

This PR will result in the following new package version:

  • v0.19.0 due to schema change

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Breaking Changes

  • Model zendesk__document is now enabled by default. To disable it, by set the zendesk__unstructured_enabled variable to false in your dbt_project.yml.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test no changes to incremental

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

  • testing without setting any variables confirms zendesk__document is created.
    Screenshot 2024-10-10 at 1 40 31 PM

If you had to summarize this PR in an emoji, which would it be?

💃

@fivetran-catfritz fivetran-catfritz self-assigned this Oct 10, 2024
@fivetran-catfritz fivetran-catfritz changed the base branch from main to feature/historical-schedules October 10, 2024 18:42
@fivetran-catfritz fivetran-catfritz changed the base branch from feature/historical-schedules to main October 10, 2024 21:09
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few change requests before this will be good. Also, with this being a pre-release we may want to hold off merging anything since we'll likely cut the release off the branch.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
fivetran-catfritz and others added 2 commits October 10, 2024 16:53
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
@fivetran-catfritz fivetran-catfritz marked this pull request as ready for review October 10, 2024 21:56
@fivetran-catfritz fivetran-catfritz changed the base branch from main to release/v0.19.0 October 10, 2024 22:24
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Last request here would be to update the README to explicitly callout the pre-release version (like we did here for v0.8.0-b1).

Once that's updated this should be good to create a pre-release off the release branch!

Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fivetran-catfritz fivetran-catfritz merged commit cf17256 into release/v0.19.0 Oct 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants