Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some changes to logging and initialization logic. #207

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Some changes to logging and initialization logic. #207

merged 4 commits into from
Dec 8, 2023

Conversation

mdwelsh
Copy link
Contributor

@mdwelsh mdwelsh commented Dec 7, 2023

These changes are meant to address a couple of startup issues:

  • There is a separate 'startAudio()' step that can be optionally called before 'start()' to get mic permissions before the peer starts speaking.
  • Added a 'audioContext.resume()' in '.startAudio()' to fix issues where the AudioContext was initialized outside of a click handler and needed to be resumed.
  • Added a bit of extra logging to help with debugging.
  • There are some minor style cleanups here mostly to make lint happy.

@mdwelsh mdwelsh requested a review from juberti December 7, 2023 22:44
juberti
juberti reviewed Dec 7, 2023
View reviewed changes
packages/fixie/src/voice.ts Outdated Show resolved Hide resolved
packages/fixie/src/voice.ts Outdated Show resolved Hide resolved
packages/fixie/src/voice.ts Outdated Show resolved Hide resolved
packages/fixie/src/voice.ts Outdated Show resolved Hide resolved
packages/fixie/src/voice.ts Outdated Show resolved Hide resolved
@mdwelsh mdwelsh requested a review from juberti December 8, 2023 00:07
@mdwelsh
Copy link
Contributor Author

mdwelsh commented Dec 8, 2023

PTAL

@juberti
Copy link
Contributor

juberti commented Dec 8, 2023

see one outstanding comment

@mdwelsh mdwelsh merged commit e615b3d into main Dec 8, 2023
2 checks passed
@mdwelsh mdwelsh deleted the mdw/voice-debugging branch December 8, 2023 22:59
juberti added a commit that referenced this pull request Dec 8, 2023
@juberti
Address unadressed PR comment
ae1b0c4 
Followup to #207
@juberti juberti mentioned this pull request Dec 8, 2023
Merged
juberti added a commit that referenced this pull request Dec 12, 2023
@juberti
Fix race condition with track subscriptions (#208)
bfbba64 
- Ensures our event listeners are installed before we connect to the
room to ensure we don't miss any events.
- Also includes a followup to #207, specifically
#207 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juberti juberti Awaiting requested review from juberti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdwelsh @juberti