Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This is swallowing events on android for me #2

Closed
litch opened this issue Dec 10, 2015 · 3 comments · Fixed by #14
Closed

This is swallowing events on android for me #2

litch opened this issue Dec 10, 2015 · 3 comments · Fixed by #14

Comments

@litch
Copy link
Contributor

litch commented Dec 10, 2015

If I have a TouchableHighlight within a swiper, it works great with iOS, but on an android emulator or device, the TouchableHighlight never even gets triggered. I'm not sure why.
@madwed
Copy link

madwed commented Dec 31, 2015

Do you have an example project we can look at?

@cgarvis
Copy link
Contributor

cgarvis commented Mar 21, 2016

@litch do you have some example code?

@esamattis
Copy link
Contributor

I've also found out that this works bit weird on Android. If something is made touchable with TouchableOpacity within the swiper it's really hard to get it to register the touch. It seems that when the swiper is swiped even a pixel the touch gesture gets canceled from the TouchableOpacity.

I guess the fix would be to ignore first few pixels before the swiper starts moving.

@esamattis esamattis mentioned this issue Apr 5, 2016
Merged
esamattis added a commit to esamattis/react-native-page-swiper that referenced this issue Apr 5, 2016
@esamattis
Add threshold to pan responder
c6ba104 
Fixes touchable item in the swiper on Android.

Should close fixt#2
@esamattis esamattis mentioned this issue Apr 5, 2016
Merged
esamattis added a commit to esamattis/react-native-page-swiper that referenced this issue Apr 5, 2016
@esamattis
Add threshold to pan responder
379ae78 
Fixes touchable items in the swiper on Android.

Should close fixt#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add threshold to pan responder esamattis/react-native-page-swiper
4 participants
@cgarvis @esamattis @litch @madwed