Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export abstract data type Form from Web.FormUrlEncoded module #36

Closed
cdepillabout opened this issue Oct 19, 2016 · 1 comment
Closed

export abstract data type Form from Web.FormUrlEncoded module #36

cdepillabout opened this issue Oct 19, 2016 · 1 comment

Comments

@cdepillabout
Copy link
Contributor

cdepillabout commented Oct 19, 2016 •
edited
Loading

It would be nice if the Form data type is exported from the Web.FormUrlEncoded module. There are a couple functions returning a Form (toForm, fromEntriesByKey), but there is no way to write the type of them in your own code without importing Form from Web.Internal.FormUrlEncoded.

The constructor of Form should probably not be exported.
@fizruk
Copy link
Owner

fizruk commented Oct 19, 2016

Yeah, that was probably not intended. Can you make a quick PR (with or without exporting constructor)?

cdepillabout added a commit to cdepillabout/http-api-data that referenced this issue Oct 19, 2016
@cdepillabout
Export Form datatype from the Web.FormUrlEncoded module.
91819cb 
This commit exports the abstract `Form` datatype from the
`Web.FormUrlEncoded` module.

Closes fizruk#36.
@cdepillabout cdepillabout mentioned this issue Oct 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdepillabout @fizruk