From/ToFormUrlEncoded (Do not merge) #25
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23. This isn't ready yet. Some questions:
To/FromFormUrlEncoded
don't actually expect/return url-encoded forms. Encoding and decoding happens before/after. To me this means their names should be changed toTo/FromForm
, but I wanted to see what others thought.to/parseQueryParam
in the generic instance is more correct thanto/parseUrlPiece
?gFromForm
though, and maybe that shouldn't be considered internal.GHC.Generics
and generic programming, so there may be issues here.options
for the generic stuff.I still need to check sum record types, squash some commits, and move the tests for encoding/decoding over.