-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repeat-expressions for arr macro #130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes fizyk20#110
Adds an analogue of the `[expr; LENGTH]` array initialiser to the `arr!` macro, i.e. `arr![Type; expr; LENGTH]`. Can be used in const contexts. Note that this implementation builds upon fizyk20#129, which should be reviewed/merged before this.
eggyal
added a commit
to eggyal/generic-array
that referenced
this pull request
Sep 11, 2022
Introduces a trait defining an associated constant of the `Self` type. The trait is parameterised to distinguish arbitrary constants. An implementation is provided for `GenericArray`, providing means of constructing arbitrary `GenericArray`s in const context. This plugs a gap that exists even if fizyk20#130 is merged, as generic type parameters cannot currently be referenced in const context (e.g. if the repetition length provided to the `arr!` macro comes from a type parameter).
eggyal
added a commit
to eggyal/generic-array
that referenced
this pull request
Sep 11, 2022
Introduces a trait defining an associated constant of the `Self` type. The trait is parameterised to distinguish arbitrary constants. An implementation is provided for `GenericArray`, providing means of constructing arbitrary `GenericArray`s in const context. This plugs a gap that exists even if fizyk20#130 is merged, as generic type parameters cannot currently be referenced in const context (e.g. if the repetition length provided to the `arr!` macro comes from a type parameter).
eggyal
added a commit
to eggyal/generic-array
that referenced
this pull request
Sep 11, 2022
Introduces a trait defining an associated constant of the `Self` type. The trait is parameterised to distinguish arbitrary constants. An implementation is provided for `GenericArray`, providing means of constructing arbitrary `GenericArray`s in const context. This plugs a gap that exists even if fizyk20#130 is merged, as generic type parameters cannot currently be referenced in const context (e.g. if the repetition length provided to the `arr!` macro comes from a type parameter).
eggyal
added a commit
to eggyal/generic-array
that referenced
this pull request
Sep 11, 2022
Introduces a trait defining an associated constant of the `Self` type. An implementation is provided for `GenericArray`, providing means of constructing default `GenericArray`s in const context. This plugs a gap that exists even if fizyk20#130 is merged, as generic type parameters cannot currently be referenced in const context (e.g. if the repetition length provided to the `arr!` macro comes from a type parameter).
eggyal
added a commit
to eggyal/generic-array
that referenced
this pull request
Sep 11, 2022
Introduces a trait defining an associated constant of the `Self` type. An implementation is provided for `GenericArray`, providing means of constructing default `GenericArray`s in const context. This plugs a gap that exists even if fizyk20#130 is merged, as generic type parameters cannot currently be referenced in const context (e.g. if the repetition length provided to the `arr!` macro comes from a type parameter).
eggyal
added a commit
to eggyal/generic-array
that referenced
this pull request
Sep 11, 2022
Introduces a trait defining an associated constant of the `Self` type. An implementation is provided for `GenericArray`, providing means of constructing default `GenericArray`s in const context. This plugs a gap that exists even if fizyk20#130 is merged, as generic type parameters cannot currently be referenced in const context (e.g. if the repetition length provided to the `arr!` macro comes from a type parameter).
eggyal
added a commit
to eggyal/generic-array
that referenced
this pull request
Nov 5, 2022
Utilises the `const-default` crate (behind a feature gate) to introduce a trait defining an associated constant of the `Self` type. An implementation is provided for `GenericArray`, providing means of constructing default `GenericArray`s in const context. This plugs a gap that exists even after fizyk20#130 was merged, as generic type parameters cannot currently be referenced in const context (e.g. if the repetition length provided to the `arr!` macro comes from a type parameter).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an analogue of the
[expr; LENGTH]
array initialiser to thearr!
macro, i.e.
arr![Type; expr; LENGTH]
. Can be used in const contexts.Note that this implementation builds upon #129, which should be
reviewed/merged before this.