Skip to content

Commit

Permalink
adjust for changes in lsm-tree
Browse files Browse the repository at this point in the history
  • Loading branch information
marvin-j97 committed Oct 30, 2024
1 parent 0e16974 commit d88f8ba
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 5 deletions.
13 changes: 11 additions & 2 deletions src/flush/worker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,18 @@ fn run_flush_worker(
task.id,
&task.sealed_memtable,
eviction_threshold,
)?;
);

// TODO: test this after a failed flush
if segment.is_err() {
// IMPORTANT: Need to decrement pending segments counter
if let crate::AnyTree::Blob(tree) = &task.partition.tree {
tree.pending_segments
.fetch_sub(1, std::sync::atomic::Ordering::Release);
}
}

Ok(segment)
Ok(segment?)
}

struct MultiFlushResultItem {
Expand Down
2 changes: 1 addition & 1 deletion src/journal/marker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ mod tests {
value_type: ValueType::Value,
};

let serialized_data = item.encode_into_vec()?;
let serialized_data = item.encode_into_vec();
let mut reader = &serialized_data[..];
let deserialized_item = Marker::decode_from(&mut reader)?;

Expand Down
4 changes: 2 additions & 2 deletions tests/partition_recover.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ fn reload_partition_config() -> fjall::Result<()> {
),
)?;

tree.config.encode_into_vec()?
tree.config.encode_into_vec()
};

{
let keyspace = Config::new(&folder).open()?;
let tree = keyspace.open_partition("default", PartitionCreateOptions::default())?;
assert_eq!(serialized_config, tree.config.encode_into_vec()?);
assert_eq!(serialized_config, tree.config.encode_into_vec());
}

Ok(())
Expand Down

0 comments on commit d88f8ba

Please sign in to comment.