Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializable Snapshot Isolation (SSI) #79

Merged
merged 85 commits into from
Oct 19, 2024
Merged

Conversation

jeromegn
Copy link
Contributor

@jeromegn jeromegn commented Sep 22, 2024

This allows multiple concurrent write transactions.

Checklist

  • Change MSRV back to 1.74
  • Uncomment unwrap_used lint
  • Remove #[inline] attributes
  • Keep the option to use the single-writer transaction type
  • Remove dependency on wmark (copy just the necessary parts into here), or maybe extract SnapshotTracker into a generic Watermark (probably needs a rewrite)
  • Increment snapshot tracker watermark, so that old MVCC versions can be freed
  • Verify that TxPartition does not create a cyclic Arc to TxKeyspace
  • Clean up unused, commented code
  • Look at TODO comments in write_tx
  • More tests (ranges, prefix, fetch_update, update_fetch, etc.)
  • Make sure memory usage has an upper bound (stuff is getting GC'ed in the transaction manager)
  • Make CI pass
  • Think about lifetime on Transaction (dangling iter)
  • Benchmarks (WriteSet::insert was marked as SLOW function... cannot be sped up by SSI tx...)

@marvin-j97 marvin-j97 added enhancement New feature or request epic test api labels Sep 22, 2024
src/tx/write_tx.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@marvin-j97 marvin-j97 changed the base branch from main to 2.2.0 October 18, 2024 21:03
@marvin-j97 marvin-j97 changed the base branch from 2.2.0 to ssi October 19, 2024 21:19
src/tx/partition.rs Show resolved Hide resolved
This reverts commit 40499fc.
false positive because of conditional compilation
@marvin-j97 marvin-j97 changed the base branch from ssi to main October 19, 2024 22:31
@marvin-j97
Copy link
Collaborator

Thanks! I would give you the moon

@marvin-j97 marvin-j97 merged commit e6c325d into fjall-rs:main Oct 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request epic test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants