Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADX-949 ckanext-validation upgrade #132

Merged

Conversation

ChasNelson1990
Copy link
Member

@ChasNelson1990 ChasNelson1990 commented Feb 9, 2023

Description

Feature branch for ADX-949 epic.

Epic: https://fjelltopp.atlassian.net/browse/ADX-949

relates fjelltopp/adx_deploy#350
relates fjelltopp/ckanext-validation#103 - including changes pushed upstream and Fjelltopp-specific patches
relates fjelltopp/ckanext-unaids#271 - Fjelltopp-specific logic and custom badges
relates fjelltopp/unaids_data_specifications#58 - potential breaking change

Dependency changes

  • submodules updated:
    • ckanext-validation
    • ckanext-unaids
    • unaids_data_specification
    • other submodules brought into line with main branch
  • python dependencies updated:
    • frictionless locked to use our fork with jinja version locked to 2.10.1
    • frictionless-geojson added
    • jinja2 locked to 2.10.1
    • tableschema added
    • other changes brought into line with main branch

Checklist

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.

@ChasNelson1990 ChasNelson1990 force-pushed the ADX-958_make_scheming_with_upstream_validation branch from 0b9212e to f94f099 Compare May 12, 2023 13:25
@ChasNelson1990 ChasNelson1990 changed the title ADX-958 make fjelltopp/ckanext-scheming compatible with upstream frictionless/ckanext-validation ADX-949 move to upstream ckanext-validation May 12, 2023
@ChasNelson1990 ChasNelson1990 added the enhancement New feature or request label May 12, 2023
@ChasNelson1990 ChasNelson1990 force-pushed the ADX-958_make_scheming_with_upstream_validation branch from 48b4eee to 067cd32 Compare May 24, 2023 09:16
@ChasNelson1990 ChasNelson1990 force-pushed the ADX-958_make_scheming_with_upstream_validation branch from 067cd32 to 18fb07f Compare July 5, 2023 09:13
@ChasNelson1990 ChasNelson1990 force-pushed the ADX-958_make_scheming_with_upstream_validation branch from 18fb07f to bfb18c2 Compare July 5, 2023 09:23
@ChasNelson1990 ChasNelson1990 force-pushed the ADX-958_make_scheming_with_upstream_validation branch from 77cb8fe to 2ef48c9 Compare August 9, 2023 08:11
@ChasNelson1990 ChasNelson1990 marked this pull request as ready for review August 9, 2023 08:20
Pipfile Outdated Show resolved Hide resolved
ckan/bootstrap.sh Outdated Show resolved Hide resolved
@fulior fulior assigned ChasNelson1990 and unassigned fulior Aug 9, 2023
@tomeksabala tomeksabala merged commit 9957bd7 into development Aug 10, 2023
1 check passed
@tomeksabala tomeksabala deleted the ADX-958_make_scheming_with_upstream_validation branch August 10, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants