Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make banner icon colour parameterised #12

Merged
merged 2 commits into from
Aug 30, 2024
Merged

fix: make banner icon colour parameterised #12

merged 2 commits into from
Aug 30, 2024

Conversation

ChasNelson1990
Copy link
Member

Description

🥫 - as it says on the tin!

Checklist

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@ChasNelson1990 ChasNelson1990 added the bug Something isn't working label Aug 30, 2024
@ChasNelson1990 ChasNelson1990 self-assigned this Aug 30, 2024
@ChasNelson1990 ChasNelson1990 enabled auto-merge (squash) August 30, 2024 14:46
A-Souhei
A-Souhei approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@A-Souhei A-Souhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ChasNelson1990 ChasNelson1990 merged commit aab1f69 into main Aug 30, 2024
0 of 2 checks passed
@ChasNelson1990 ChasNelson1990 deleted the small-ui-improvements branch August 30, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-Souhei A-Souhei A-Souhei approved these changes

Assignees

@ChasNelson1990 ChasNelson1990

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChasNelson1990 @A-Souhei