Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility changes for CKAN 2.10 #3

Merged
merged 9 commits into from
Oct 2, 2024
Merged

Compatibility changes for CKAN 2.10 #3

merged 9 commits into from
Oct 2, 2024

Conversation

A-Souhei
Copy link
Contributor

@A-Souhei A-Souhei commented Sep 19, 2024

Description

The commit will make a few changes for CKAN 2.10 to be compatible.
Closes fjelltopp/zarr-ckan#156

Dependency Changes (delete if not applicable)

dev-requirements have been upated.

Testing (delete if not applicable)

  • Created a tag 1.0.0 for CKAN 2.9 tests
  • Test use matrix
  • Docker images have been updated (previous ones are no more maintained)

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@A-Souhei A-Souhei added the enhancement New feature or request label Sep 19, 2024
@A-Souhei A-Souhei self-assigned this Sep 19, 2024
@A-Souhei A-Souhei added the patch label Sep 19, 2024
@A-Souhei A-Souhei marked this pull request as ready for review September 20, 2024 07:07
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only question is about our tagging and support strategy.

.github/workflows/test.yml Show resolved Hide resolved
@A-Souhei
Copy link
Contributor Author

A-Souhei commented Oct 2, 2024

Forgot to update readme, sorry, doing that

@A-Souhei A-Souhei marked this pull request as draft October 2, 2024 13:36
@A-Souhei A-Souhei marked this pull request as ready for review October 2, 2024 13:45
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@A-Souhei A-Souhei merged commit 2205da8 into master Oct 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ckanext-short-urls
2 participants