WRC-70 Update get_facet_items_dict with latest changes from core CKAN #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Getting ridiculously large numbers of warnings saying:
The problem is that in order to create our own ordering of facets we had to take a copy of a ckan core helper and make some minor modifications to the middle of it's logic. This code copied from ckan core is now referencing deprecated elements.
This PR just copies across the latest changes from CKAN core so it is no longer referencing deprecated elements.
@ChasNelson1990 This change will need to be ported to AFRO as well here. Should be an exact port I think and super quick.
Checklist
Put an
x
in the boxes that apply to this pull request (you can also fill these out after opening the pull request).You may not need to check all boxes.