Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRC-70 Update get_facet_items_dict with latest changes from core CKAN #19

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jonathansberry
Copy link
Member

@jonathansberry jonathansberry commented Sep 5, 2024

Description

Getting ridiculously large numbers of warnings saying:

Function is_flask_request() in module ckan.common has been deprecated since CKAN v2.10.0 and will be removed in a later release of ckan. All web requests are served by Flask"

The problem is that in order to create our own ordering of facets we had to take a copy of a ckan core helper and make some minor modifications to the middle of it's logic. This code copied from ckan core is now referencing deprecated elements.

This PR just copies across the latest changes from CKAN core so it is no longer referencing deprecated elements.

@ChasNelson1990 This change will need to be ported to AFRO as well here. Should be an exact port I think and super quick.

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChasNelson1990
Copy link
Member

@mixmixmix leaving this for you to merge

@mixmixmix mixmixmix merged commit c5efa0b into master Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants