Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erbのシンタックスハイライトをサポート #2417

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

universato
Copy link
Contributor

PR #2353 と同じで、erb版です。
@mh-mobile さんに、erbがmarkup-templatingに依存していることを教えてもらったので、それも含めています。

Image from Gyazo

@mh-mobile
Copy link
Contributor

補足ですが、erbが何に依存しているかは、以下のcomponent.jsonのrequire属性を見ると定義されているようです。

"erb": {
	"title": "ERB",
	"require": ["ruby", "markup-templating"],
	"owner": "Golmote"
},

https://github.com/PrismJS/prism/blob/gh-pages/components.json#L238-L242

上記では、erbがrubyとmarkup-templartingに依存していることが分かります。

言語が依存性を持つことについては、以下のissueで言及があったので、記載しておきます。

It's not a bug. However you decide to consume Prism, you need to make sure the languages have their dependencies satisfied. Those dependencies are described here. You can see here that handlebars has a dependency on markup-templating.

PrismJS/prism#1394 (comment)

Base automatically changed from master to main March 5, 2021 06:52
Copy link
Member

@komagata komagata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@komagata komagata merged commit d7200e4 into main Mar 5, 2021
@komagata komagata deleted the feature/markdown_erb_support branch March 5, 2021 12:52
@github-actions github-actions bot mentioned this pull request Mar 5, 2021
10 tasks
@universato universato self-assigned this May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants