ダッシュボード配下に自分の提出物一覧をページを作成 #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udaikue
force-pushed
the
feature/add_dashboard_and_my_products_page_tabs_in_home
branch
from
73caf33 to
34fee6a
Compare
|
@yana-gi お手すきのときにレビューをお願いします🙏ペアプロのissueです。 |
yana-gi
reviewed
Jul 17, 2021
config/routes.rb
Outdated
Comment on lines
108
to
111
| namespace :current_user do | ||
| resources :products, only: %i(index) | ||
| end | ||
|
|
There was a problem hiding this comment.
既にある96-98行目のnamespace :current_userに追加するようにしてください〜
Comment on lines
7
to
11
| .page-header-actions | ||
| ul.page-header-actions__items | ||
| li.page-header-actions__item | ||
| = link_to users_path, class: 'a-button is-md is-secondary is-block is-back' do | ||
| | ユーザー一覧 |
There was a problem hiding this comment.
以前machidaさんに確認したところ、この画面にはユーザー一覧ボタンは不要とのことでした。
ので削除しちゃってください〜
#2844 (comment)
事前に共有できずすみません……！
There was a problem hiding this comment.
いえ、ありがとうございます。修正しました！
udaikue
force-pushed
the
feature/add_dashboard_and_my_products_page_tabs_in_home
branch
from
9fbb70f to
fae0070
Compare
|
@yana-gi 色々指摘してくださりありがとうございます！修正しましたので、改めてご確認お願いします🙏 |
yana-gi
approved these changes
Jul 18, 2021
|
レビュワーに駒形さんを追加しましたー
|
|
@udaikue デザイン確認しました。OKですー🙆♂️ |
komagata
approved these changes
Jul 20, 2021
| @@ -95,6 +95,7 @@ | |||
|
|
|||
| namespace :current_user do | |||
| resources :reports, only: %i(index) | |||
| resources :products, only: %i(index) | |||
komagata
deleted the
feature/add_dashboard_and_my_products_page_tabs_in_home
branch
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #2843
ダッシュボードに自分の提出物一覧のタブを作成しました。
変更前
変更後