【メンター向け機能】提出物に未アサインタブを追加 #3027
Merged
【メンター向け機能】提出物に未アサインタブを追加 #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fugakkbn
force-pushed
the
feature/add-not-assigned-tab-to-products-page
branch
from
20ac369 to
ef04a58
Compare
|
@gallardo16 こちらのレビューお願いできますでしょうか🙏 |
fugakkbn
force-pushed
the
feature/add-not-assigned-tab-to-products-page
branch
from
ef04a58 to
3f35f11
Compare
gallardo16
approved these changes
Aug 2, 2021
fugakkbn
force-pushed
the
feature/add-not-assigned-tab-to-products-page
branch
from
f24322c to
693051e
Compare
|
@gallardo16 @komagata |
fugakkbn
force-pushed
the
feature/add-not-assigned-tab-to-products-page
branch
from
693051e to
f8bcfc3
Compare
komagata
requested changes
Aug 8, 2021
| if (location.pathname === '/products/not_responded') { | ||
| if ( | ||
| location.pathname === '/products/not_responded' || | ||
| location.pathname === '/products/unassigned' |
There was a problem hiding this comment.
/products/unassigned?read=falseみたいにパラメーターが追加されたときに動きがおかしくなったりは大丈夫でしょうか～？
There was a problem hiding this comment.
#3067 (comment)
こちらでやりとりさせてもらったのと同様に、クエリパラメーターが追加されても大丈夫そうです🙆🏻♂️
念のため動作確認もしましたが挙動は変わらずでした。
fugakkbn
force-pushed
the
feature/add-not-assigned-tab-to-products-page
branch
from
c01d04a to
49a14fe
Compare
|
@komagata |
komagata
requested changes
Aug 10, 2021
test/system/products_test.rb
Outdated
| initial_counter = unassigned_tab.text | ||
|
|
||
| assignee_buttons = all('.a-button.is-block.is-secondary.is-sm', text: '担当する') | ||
| assignee_buttons.first(3).each(&:click) |
There was a problem hiding this comment.
3つめというのは必然性がなく、今後のレイアウト変更などで変わりやすいのですぐにテストがうごかなくなっちゃいそうなので、他の条件にしたいですね。（hashとarrayの違いのように。hashは名前でしていするので順番がかわっても問題ない）
タブにその名前を表すidやclassがついているのは問題ない（あったほうが良い）ので追加でつけちゃっても大丈夫です。
There was a problem hiding this comment.
3回「担当する」ボタンを押す必要はなさそうです😅
- 未アサインタブにidをつける
- 未アサインタブ内のカウンターにidをつける
- 「担当する」ボタンのクリックを1回だけしてカウンターが変化していることを検証する
という形に修正しました🙆🏻♂️
fugakkbn
force-pushed
the
feature/add-not-assigned-tab-to-products-page
branch
from
49a14fe to
e57d961
Compare
|
@komagata テストの修正をしましたのでご確認お願いいたします🙏 |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #3021
やったこと
メンター用の提出物一覧ページのタブに「未アサイン」タブを追加しました。
変更前
変更後
「未アサイン」タブの仕様
テスト項目