Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UsersテーブルからSlack関連情報を削除 #3039

Merged

Conversation

fugakkbn
Copy link
Contributor

ref: #2744

やったこと

Slack関連情報を削除 · Pull Request #2957の続きの作業です。
Usersテーブルから

  • slack_account
  • slack_participation

の2つのカラムを削除するmigrationを作成しました。

今後の方針

次回のリリース時に、こちらで追加したignored_columnsの削除をして完了となります。

@fugakkbn fugakkbn requested a review from makiichikawa July 27, 2021 07:57
@fugakkbn
Copy link
Contributor Author

@makiichikawa こちらのレビューお願いいたします🙏

@fugakkbn fugakkbn self-assigned this Jul 27, 2021
Copy link
Contributor

@makiichikawa makiichikawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました〜
ロールバックもちゃんと出来るようで、安心しました。
問題ないと思います👍

@fugakkbn fugakkbn requested a review from komagata July 27, 2021 10:27
@fugakkbn
Copy link
Contributor Author

@makiichikawa レビューありがとうございます🙏
@komagata こちらのレビューお願いいたします🙏

Copy link
Member

@komagata komagata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました、OKですー🙆‍♂

@komagata komagata merged commit a0e335d into main Jul 28, 2021
@komagata komagata deleted the feature/remove-slack-account-and-participation-from-users-table branch July 28, 2021 16:31
@github-actions github-actions bot mentioned this pull request Jul 28, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants