-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
「はじめての日報を書きました!」通知は現役生とメンターのみに通知する #4012
Merged
komagata
merged 5 commits into
main
from
feature/first-daily-report-notification-should-only-be-sent-to-current-students-and-mentors
Jan 31, 2022
Merged
「はじめての日報を書きました!」通知は現役生とメンターのみに通知する #4012
komagata
merged 5 commits into
main
from
feature/first-daily-report-notification-should-only-be-sent-to-current-students-and-mentors
Jan 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maeda-seina
force-pushed
the
feature/first-daily-report-notification-should-only-be-sent-to-current-students-and-mentors
branch
from
January 24, 2022 08:07
70c5fd1
to
a5dee57
Compare
お疲れ様です! |
maeda-seina
force-pushed
the
feature/first-daily-report-notification-should-only-be-sent-to-current-students-and-mentors
branch
from
January 25, 2022 10:09
a5dee57
to
dce1d7a
Compare
maeda-seina
force-pushed
the
feature/first-daily-report-notification-should-only-be-sent-to-current-students-and-mentors
branch
from
January 26, 2022 08:43
469d86f
to
620bae6
Compare
maeda-seina
changed the title
「はじめての日報を書きました!」通知は現役生とメンターのみに通知されるようにした
「はじめての日報を書きました!」通知は現役生とメンターのみに通知する
Jan 26, 2022
@maeda-seina さん |
yoshitaku-jp
approved these changes
Jan 30, 2022
ご確認ありがとうございました! @komagata さん お疲れ様です。 |
komagata
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
確認しました、OKですー🙆♂️
komagata
deleted the
feature/first-daily-report-notification-should-only-be-sent-to-current-students-and-mentors
branch
January 31, 2022 15:29
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
概要
「はじめての日報を書きました!」通知は現役生とメンターのみに通知されるようにする
動作確認の手順
1.日報なしのユーザー(nippounashi)でログインし、日報を作成し、ログアウトする。
2.現役生ユーザー(kimuraなど)でログインし、サイト内通知とメール通知(letter_openerで確認)がきていることを確認する。(同じくこの動作をメンター(komagata)でも確認する。)
3.アドバイザー(advijirou)でログインし、サイト内通知とメール通知がきてないことを確認する。(同じくこの動作を卒業生(sotugyou)でも確認する。)
テストケースには現役生とメンターに通知がいくことを確認できるテストと、アドバイザーと卒業生には通知がいかないことを確認できるテストを作成しました。