プラクティス一覧のローディングをプレースフォルダにする #4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@machida さん お疲れ様です。 |
|
@maeda-seina 了解です！デザイン作りますー |
|
デザイン作りましたー |
maeda-seina
force-pushed
the
feature/loading-courses-practices-with-placeholder
branch
2 times, most recently
from
2b0ca35 to
65c116a
Compare
|
@R-Tsukada さん |
R-Tsukada
approved these changes
Feb 6, 2022
There was a problem hiding this comment.
@maeda-seina
動作確認できました！コードもLGTMです🎉
個人的な意見ですが、変更前後のスクショがあるとコードレビューに入りやすいと思いました。あくまでも個人的な意見なので気にされなくても大丈夫です！
|
@R-Tsukada さん
完全に忘れてしまっていたため、ご指摘いただき助かりました！！😅ありがとうございます!!🙇♂️ |
|
@komagata さん |
maeda-seina
force-pushed
the
feature/loading-courses-practices-with-placeholder
branch
from
65c116a to
21707e8
Compare
maeda-seina
force-pushed
the
feature/loading-courses-practices-with-placeholder
branch
from
21707e8 to
125fd70
Compare
|
@komagata さん |
komagata
deleted the
feature/loading-courses-practices-with-placeholder
branch
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
概要
プラクティス一覧のローディングをプレースフォルダにする。
変更前
プラクティス一覧のローディングがロード中と表示されている。
変更後
プラクティス一覧のローディングがプレースフォルダになっている。
確認手順
1.
feature/loading-courses-practices-with-placeholderブランチにチェックアウトする。2.任意のユーザーでログインする。
3.プラクティス一覧にアクセスし、ローディングがプレースフォルダになっていることを確認する。