-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
メンター・アドバイザー・管理者はダッシュボードの学習時間の草を非表示にする #4211
Merged
komagata
merged 12 commits into
main
from
feature/not-display-grass-when-mentors-advisors-and-admins-login
Mar 14, 2022
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
851ce2d
メンター・アドバイザー・管理者はダッシュボードの学習時間の草を非表示にする
Saki-htr 85a1af2
メンター・アドバイザ・管理者のダッシュボードに学習時間の草を表示しないテストを追記
Saki-htr 94c514b
草の表示条件を簡潔なものに修正
Saki-htr 4acb219
誤って作成した重複しているテストを削除
Saki-htr 5566847
テストを学習時間の草を表示する場合としない場合に分け、「そのユーザーに対してなぜ草が表示or非表示なのか」をコメントで追記
Saki-htr fa4f683
yamadaは存在しないため、mentormentaroに変更
Saki-htr e0d7fdb
コメントの並びを修正
Saki-htr 19acc71
コメントを削除し、ユーザーのロールをアサーションする処理を追加
Saki-htr 358c872
assert_selectorを使って、ダッシュボードのページにアクセスできているかを確認する処理を追加
Saki-htr b57726c
学習時間が表示されているかのテストを、より確実にするためにassert_selectorに変更した
Saki-htr d098ed1
学習時間が表示されていないかのテストを、assert_no_selectorを使ってより確実にした
Saki-htr b2bdbf3
テストを検証するユーザーごとに分けた
Saki-htr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
とってもわかりやすくなりました〜👍