Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q＆A個別ページのtitleタグの最初にQ＆Aと表示するように変更 #7045

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Q＆A個別ページのtitleタグの最初にQ＆Aと表示するように変更 #7045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05c96cd
Q＆A個別ページのtitleタグの最初にQ＆Aと表示するように変更
2525nicole Nov 9, 2023
a508f55
titleタグ表示に関するテストを修正
2525nicole Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/questions/show.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- title @question.title
- title "Q＆A #{@question.title}"
- if @question.practice
- set_meta_tags description: "#{@question.user.long_name}さんが投稿した、プラクティス「#{@question.practice}」に関する質問「#{@question.title}」のページです。"
- else
Expand Down
2 changes: 1 addition & 1 deletion test/system/questions_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class QuestionsTest < ApplicationSystemTestCase
test 'show a question' do
question = questions(:question8)
visit_with_auth question_path(question), 'kimura'
assert_equal 'テストの質問 | FBC', title
assert_equal 'Q＆A テストの質問 | FBC', title
end

test 'create a question' do
Expand Down