bookmark-buttonをVueからReactに置き換え #7488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyokucho1989
force-pushed
the
feature/convert-bookmark-button-to-react
branch
2 times, most recently
from
b195140 to
40f55bc
Compare
kyokucho1989
commented
Mar 12, 2024
| } | ||
| } | ||
| }, [data]) | ||
|
|
There was a problem hiding this comment.
data にAPIを叩いた結果が入ります。
レスポンスが返るとdataがtrueになります。
すでにブックマーク済なら data.bookmarks.length > 0 がtrue になります
kyokucho1989
commented
Mar 13, 2024
| bookmarkId = data.bookmarks[0].id | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
bookmarkId = data.bookmarks[0].id をuseEffect の中で行うとbookmarkId がnullのままとなるためこちらに移しています。
|
@taco-nantai |
|
@kyokucho1989 |
|
@taco-nantai |
kyokucho1989
force-pushed
the
feature/convert-bookmark-button-to-react
branch
from
40f55bc to
11b356b
Compare
|
@komagata |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
概要
Issueに記載。ブックマークボタンをVueからReactに置き換えました。
変更確認方法
foreman start -f Procfile.devを実行してbootcampを起動する注意
Bookmark-button.vueの動作ではないため、変更していません。Screenshot
変更前後で変わりはありません。