Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

フォームフィールドに関連付けられていないlabelタグをdivへ変更 #7491

Merged
merged 2 commits into from
Mar 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/javascript/components/NotificationsBell/BellButton.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default function BellButton({ setShowNotifications }) {
}

return (
<label
<div
onClick={() => setShowNotifications(true)}
className="header-links__link test-show-notifications">
<div className="header-links__link test-bell">
Expand All @@ -33,6 +33,6 @@ export default function BellButton({ setShowNotifications }) {
<div className="header-links__link-label">通知</div>
</div>
</div>
</label>
</div>
)
}
2 changes: 1 addition & 1 deletion app/views/home/_bookmarks.html.slim
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
h2.card-header__title
| 最新のブックマーク
.card-header__action
label.a-form-label.is-sm.is-inline
.a-form-label.is-sm.is-inline
| 編集
label.a-on-off-checkbox.is-sm.spec-bookmark-edit
input#bookmark_edit(type='checkbox')
Expand Down