Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flakyなテストを修正 #7504

Merged
merged 2 commits into from
Mar 19, 2024
Merged

flakyなテストを修正 #7504

merged 2 commits into from
Mar 19, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 7, 2024

Issue

概要

以下のflakyなテストを修正しました

  • edit user tag
  • update user tags
  • company logo appear when adviser belongs to the company post comment
  • attachment company icons in reports
  • the company logo is shown when an adviser who belongs to a company posts an answer

変更確認方法

  1. feature/fix-flaky-testsをローカルに取り込む
  2. edit user tagupdate user tagsがローカル環境でのテストで失敗しないことを確認する(他の3件は元からローカルでは失敗しないため)

@ghost ghost force-pushed the feature/fix-flaky-tests branch from 78fa75e to e0b1ba6 Compare March 7, 2024 10:34
@ghost ghost self-assigned this Mar 7, 2024
@ghost ghost force-pushed the feature/fix-flaky-tests branch from 5653443 to e0b1ba6 Compare March 8, 2024 01:44
@ghost ghost mentioned this pull request Mar 8, 2024
@ghost ghost marked this pull request as ready for review March 10, 2024 12:04
@ghost ghost requested a review from hirano-vm4 March 10, 2024 12:08
@ghost
Copy link
Author

ghost commented Mar 10, 2024

@hirano-vm4
お疲れ様です。
こちらのPRのレビューをお願いしてもよろしいでしょうか🙏
お手すきの際で構いませんので、よろしくお願いいたします🙇‍♂️

@hirano-vm4
Copy link
Contributor

@taco-nantai

お疲れ様です!レビュー依頼ありがとうございます〜承知しました🙆

数日以内に確認してお返しします😄

@hirano-vm4
Copy link
Contributor

hirano-vm4 commented Mar 14, 2024

@taco-nantai

大変お待たせしました!以下のように私のローカル環境ではパスできましたので、Approveさせていただきます🙏

update user tags (test/system/current_user/tags_test.rb)

~/FBC-App/bootcamp_app/bootcamp feature/fix-flaky-tests ⇣⇡
❯ CI=1 PARALLEL_WORKERS=1 bin/rails test test/system/current_user/tags_test.rb
Running via Spring preloader in process 33902
Run options: --seed 9135

# Running:

Finished in 37.599034s, 0.0798 runs/s, 0.1330 assertions/s.
3 runs, 5 assertions, 0 failures, 0 errors, 0 skips

edit user tag(test/system/admin/users_test.rb)

~/FBC-App/bootcamp_app/bootcamp feature/fix-flaky-tests ⇣⇡ 38s
❯ CI=1 PARALLEL_WORKERS=1 bin/rails test test/system/admin/users_test.rb      
Running via Spring preloader in process 38834
Run options: --seed 9360

# Running:

Finished in 111.621397s, 0.3315 runs/s, 0.6540 assertions/s.
37 runs, 73 assertions, 0 failures, 0 errors, 0 skips

@ghost
Copy link
Author

ghost commented Mar 15, 2024

@hirano-vm4
お疲れ様です。
レビューありがとうございました🙇‍♂️

@ghost ghost requested a review from komagata March 15, 2024 04:51
@ghost
Copy link
Author

ghost commented Mar 15, 2024

@komagata
お疲れ様です。
PRにapproveをいただいたので、レビューをお願いします🙇‍♂️

Copy link
Member

@komagata komagata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認させていただきました。OKです~👌

@komagata komagata merged commit 2787cf4 into main Mar 19, 2024
10 checks passed
@komagata komagata deleted the feature/fix-flaky-tests branch March 19, 2024 09:36
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants