Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

都道府県別ユーザー一覧の非React化 #8034

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

都道府県別ユーザー一覧の非React化 #8034

wants to merge 30 commits into from

Commits on Sep 13, 2024

  1. 地域別ユーザーの一覧画面の非React版を作成 

    - 既存コードの削除は未実施
- ページネーションは未実施
    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    918bdc2 View commit details
    Browse the repository at this point in the history

  2. ページネーションを実装

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5616d45 View commit details
    Browse the repository at this point in the history

  3. 都道府県に対するユーザー一覧ページを作成 

    - サイドメニューは未実装
    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d218c98 View commit details
    Browse the repository at this point in the history

  4. 都道府県ユーザー一覧ページに都道府県一覧ページへ戻るボタンを追加

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    242e28a View commit details
    Browse the repository at this point in the history

  5. 都道府県ユーザー一覧ページにサイドメニューを追加

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e79079a View commit details
    Browse the repository at this point in the history

  6. サイドメニューをパーシャルに切り出し

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    12ba51d View commit details
    Browse the repository at this point in the history

  7. 不要なコードを削除

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    38b6299 View commit details
    Browse the repository at this point in the history

  8. rubocop対応

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    83495e4 View commit details
    Browse the repository at this point in the history

  9. Reactを呼び出す不要なコードを削除

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2bbf37d View commit details
    Browse the repository at this point in the history

  10. 都道府県ユーザー一覧ページでもタブがアクティブになるように修正

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ef8ea66 View commit details
    Browse the repository at this point in the history

  11. 不要な行を削除

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    502a3d1 View commit details
    Browse the repository at this point in the history

  12. 都道府県一覧ページの上部にもページネーションを追加

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0678ab2 View commit details
    Browse the repository at this point in the history

  13. ユーザー一覧の既存のパーシャルがusers_controller以外に対応していないため、areas_controllerに対応するパーシ… 

    …ャルを作成
    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7a9cec5 View commit details
    Browse the repository at this point in the history

  14. subdivisionがnilの場合はnilを返すように修正

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    286f0e8 View commit details
    Browse the repository at this point in the history

  15. ユーザーが住んでいるareaを取得するメソッドをuserモデルに移動

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b6650f3 View commit details
    Browse the repository at this point in the history

  16. システムテストを作成

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    63e5ef1 View commit details
    Browse the repository at this point in the history

  17. モデルテストを作成

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3d141c3 View commit details
    Browse the repository at this point in the history

  18. 既存テストと干渉するため、areaを持たせるfixtureを変更

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    647404e View commit details
    Browse the repository at this point in the history

  19. areaから移動したメソッドのモデルテストを作成

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c59208e View commit details
    Browse the repository at this point in the history

  20. 条件式での代入を修正

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    413b4be View commit details
    Browse the repository at this point in the history

  21. エリアごとのユーザー数でソートしたユーザーのグループを返すメソッドを修正 

        - メソッドが返すのはエリアごとに分けられた「複数のグループ」のため、メソッド名をわかりやすく修正
    - メソッド名の変更に伴い、テストを修正
    - メソッド名の変更に伴い、コントローラーからの呼び出しを修正
    - ユーザー取得時にソートするように修正
    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    621c316 View commit details
    Browse the repository at this point in the history

  22. users_by_areメソッドをUserモデルのメソッドに移動 

    - user_by_areaメソッドはusersを返すためUserモデルに移動
- テストやコントローラを合わせて修正
    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e7b6f7e View commit details
    Browse the repository at this point in the history

  23. パラメータ名を簡潔に修正

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    63fb5ad View commit details
    Browse the repository at this point in the history

  24. 不要なルーティングを削除

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    fc1a453 View commit details
    Browse the repository at this point in the history

  25. ユーザーグループ分けの一覧のカードを別々にした

    @machida @Shrimprin
    machida authored and Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7dbde27 View commit details
    Browse the repository at this point in the history

  26. パラメータ名の修正漏れを対応

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    36d094b View commit details
    Browse the repository at this point in the history

  27. 省略形に修正

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6e3075b View commit details
    Browse the repository at this point in the history

  28. メソッド名が簡潔になるように修正

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2311f4f View commit details
    Browse the repository at this point in the history

  29. マジックナンバーを定数化

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ee818c6 View commit details
    Browse the repository at this point in the history

  30. テスト名を修正

    @Shrimprin
    Shrimprin committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d1ab442 View commit details
    Browse the repository at this point in the history