Skip to content

extended extract_t0 by postfix argument, default stays .ms #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

jkuhl-uni
Copy link
Collaborator

Hi,
contrary to the currently implemented solution, I need the postfix used for the extraction of t0 to be .ms3.
I therefore did a small fix, in which you can now optionally also hand over a postfix to this method, similar to what is already implemented in read_rwms().
The default is still .ms, as this would break backwards compatibility otherwise.
PS: Sorry for the typo in the branch name :)

@jkuhl-uni jkuhl-uni requested a review from fjosw as a code owner March 24, 2023 09:45
Copy link
Owner

@fjosw fjosw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@fjosw fjosw merged commit 9d67738 into fjosw:develop Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants