Skip to content

new variant of second derivative, bigger stencil #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 10, 2023

Conversation

jkuhl-uni
Copy link
Collaborator

Hello there,
I need another derivative for one of my projects, so I implemented it.
Of course, we can change the name, I just thought it would be practical to directly implement this is the Corr class.
If this is a use-case that is too niche I understand and you can discard this pull request.

@jkuhl-uni jkuhl-uni requested a review from fjosw as a code owner July 7, 2023 13:40
Copy link
Owner

@fjosw fjosw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I would be happy to include the additional derivative. Can you please fix the linting error and add an explanation of the new type of derivative to the docstring?

@fjosw
Copy link
Owner

fjosw commented Jul 10, 2023

I think for the math to work you need to use a raw string (r""" or r''').

@jkuhl-uni
Copy link
Collaborator Author

I think you are right, I oversaw this

@fjosw fjosw merged commit 94b0322 into fjosw:develop Jul 10, 2023
@jkuhl-uni jkuhl-uni deleted the feat/newsecderiv branch July 10, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants