Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for addition and multiplication of complex numbers to Corr objects #209

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Added support for addition and multiplication of complex numbers to Corr objects #209

merged 1 commit into from
Jul 21, 2023

Conversation

fjosw
Copy link
Owner

@fjosw fjosw commented Jul 21, 2023

I added the missing overloading of the addition of Obs and complex and the addition and multiplication of Corr and complex types.

@fjosw fjosw requested a review from s-kuberski July 21, 2023 10:59
s-kuberski
s-kuberski approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@s-kuberski s-kuberski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thanks!

@fjosw fjosw merged commit 7f8c2ce into develop Jul 21, 2023
10 checks passed
@fjosw fjosw deleted the feat/complex_add_mul branch July 21, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-kuberski s-kuberski s-kuberski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fjosw @s-kuberski