Fix keyword files with list of lists #226
Conversation
|
Hi, |
|
With ll. 239, my changes do not break backwards compatibility. |
There was a problem hiding this comment.
Thanks for taking care of this @jkuhl-uni. I left two small comments.
| if isinstance(files, list): | ||
| if isinstance(files[0], list): | ||
| files = files[i] | ||
|
|
There was a problem hiding this comment.
What happens if files is not of type list[list[int]]? Maybe we should add an explicit exception here or is there a type check somewhere else that I overlooked?
There was a problem hiding this comment.
Hi, sorry it took some time, I put explicit type checks in both places where kwargs.get('files') is used and just put two tests.
| @@ -309,7 +313,7 @@ def read_sfcf_multi(path, prefix, name_list, quarks_list=['.*'], corr_type_list= | |||
| w = specs[3] | |||
| w2 = specs[4] | |||
| if "files" in kwargs: | |||
| ls = kwargs.get("files") | |||
There was a problem hiding this comment.
Was this a bug? Did the code work before when specifying the kwarg files?
There was a problem hiding this comment.
AFAIK this worked, but the thing is that the files-keyword didn't do anything in this case... With this, it would give you the option to (at least) say which ids you want, however, this is of course nto the same kind of control you have in the other cases, where you can actually say which idls you want.
For this to work, we would need to implement something similar to #185 for this read method. I coudl also take care of that, but I need some time for that I think.
Hi,
this is the first version of an implementation to solve #225. This is using a list of lists.
It can easily be adapted to use dicts.