Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types definitions issue #110

Closed
TonticiOleg opened this issue Dec 22, 2017 · 1 comment
Closed

types definitions issue #110

TonticiOleg opened this issue Dec 22, 2017 · 1 comment
Assignees
@fkhadra
Labels
bug

Comments

@TonticiOleg
Copy link

TonticiOleg commented Dec 22, 2017 •
edited
Loading

wanted to create a pull request but..

In type definitions file - method signature declaration is wrong - mean cannot be compiled
type ToastContent = React.ReactNode | () => void; instead of
type ToastContent = React.ReactNode | { () : void };
fkhadra added a commit that referenced this issue Dec 22, 2017
@fkhadra
Fix ts definition #110
8c54fb6
@fkhadra
Copy link
Owner

fkhadra commented Dec 22, 2017

Hey @TonticiOleg,

Thank you for reporting the issue. Just pushed a new build. It will be live in a few minute.

@fkhadra fkhadra closed this as completed Dec 22, 2017
@fkhadra fkhadra self-assigned this Dec 22, 2017
@fkhadra fkhadra added the bug label Dec 22, 2017
vasiliydolmatov pushed a commit to vasiliydolmatov/react-toastify that referenced this issue Apr 2, 2019
@fkhadra
Fix ts definition fkhadra#110
99b080f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkhadra fkhadra

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fkhadra @TonticiOleg