Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloseButtonProps are no longer exported from types in version 10 #1165

Closed
gustaff-weldon opened this issue Oct 10, 2024 · 1 comment
Closed
Labels
bug Merged in next Merged but not live

Comments

@gustaff-weldon
Copy link

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
CloseButtonProps were previously exported in index.ts in version 9. From version 10 they are missing. One has to import them from import type { CloseButtonProps } from 'react-toastify/dist/components'; which is prone to breaking if structure changes.

What is the expected behavior?
import type { CloseButtonProps } from 'react-toastify';

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
React 18.3.1, toastify 10.0.5

@fkhadra fkhadra added the bug label Dec 1, 2024
fkhadra added a commit that referenced this issue Dec 1, 2024
@fkhadra fkhadra added the Merged in next Merged but not live label Dec 1, 2024
@fkhadra fkhadra mentioned this issue Dec 10, 2024
fkhadra added a commit that referenced this issue Dec 16, 2024
@fkhadra
Copy link
Owner

fkhadra commented Dec 16, 2024

Hey @gustaff-weldon , I've released a new major version, please read the release note before upgrading 🙏🏽

@fkhadra fkhadra closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Merged in next Merged but not live
Projects
None yet
Development

No branches or pull requests

2 participants