Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrapping div className "Toastify" #186

Closed
sinplex opened this issue May 31, 2018 · 1 comment
Closed

wrapping div className "Toastify" #186

sinplex opened this issue May 31, 2018 · 1 comment
Assignees
@fkhadra

Comments

@sinplex
Copy link

sinplex commented May 31, 2018

You could consider adding the className "Toastify" to the wrapping div of the component for sake of BEM conformity and to not have a div with no use. Realy nice work thogh!
@fkhadra fkhadra self-assigned this May 31, 2018
@fkhadra
Copy link
Owner

fkhadra commented May 31, 2018

@sinplex you're right

fkhadra added a commit that referenced this issue Jun 4, 2018
@fkhadra
BEM: Fix issue #186
70c1628
@fkhadra fkhadra closed this as completed Jun 4, 2018
vasiliydolmatov pushed a commit to vasiliydolmatov/react-toastify that referenced this issue Apr 2, 2019
@fkhadra
BEM: Fix issue fkhadra#186
d130696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkhadra fkhadra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fkhadra @sinplex