Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onClose not executed on v6.0.4 #476

Closed
AdrienLemaire opened this issue May 15, 2020 · 1 comment
Closed

onClose not executed on v6.0.4 #476

AdrienLemaire opened this issue May 15, 2020 · 1 comment
Assignees
@fkhadra
Labels
bug

Comments

@AdrienLemaire
Copy link

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
onOpen works.
onClose doesn't.

What is the expected behavior?
onClose callback should be executed when the toast closes
@fkhadra fkhadra self-assigned this May 19, 2020
@fkhadra fkhadra added the bug label May 19, 2020
@fkhadra
Copy link
Owner

fkhadra commented May 19, 2020

The issue seems related to the new version of react-transition-group. My tests didn't catch it because react-transition-group is mocked. Thanks for reporting the issue

fkhadra added a commit that referenced this issue May 20, 2020
@fkhadra
Merge pull request #479 from fkhadra/onClose-not-executed-
2a44067 
fix #476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkhadra fkhadra

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AdrienLemaire @fkhadra