Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DomainResolver deletes logs in some cases #433

Closed
Malutthias opened this issue Aug 7, 2023 · 3 comments
Closed

DomainResolver deletes logs in some cases #433

Malutthias opened this issue Aug 7, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Malutthias
Copy link
Collaborator

Some logs are deleted in the logprep while processing in domain_resolver preprocessor.

ProcessingCriticalError in DomainResolver (domain_resolver): encoding with 'idna' codec failed (UnicodeError: l_abel empty or too long_) -> event was deleted

Expected behavior

Writing to an error index with descriptive error message.

Current behavior

Deletion of relevant logs

Steps to reproduce

Running logprep and process examples with either an empty label or too long a lable for the domain_resolver.

Environment

Logprep version: latest
Python versions: 3.11
Environment: Kubernetes with containerd

@Malutthias Malutthias added the bug Something isn't working label Aug 7, 2023
@dtrai2
Copy link
Collaborator

dtrai2 commented Aug 8, 2023

Can you please double check if you are using the latest version? We made a release last thursday and the MR #428 should have fixed this already.

@Malutthias
Copy link
Collaborator Author

Ok, admin says we're on 23.07.03 in our test system were it happened. We'll check

@Malutthias
Copy link
Collaborator Author

Works as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants