Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix crash on invalid json input in kafka input connector #428

Merged
merged 6 commits into from
Jul 21, 2023
Merged

fix crash on invalid json input in kafka input connector #428

merged 6 commits into from
Jul 21, 2023

Conversation

dtrai2
Copy link
Collaborator

@dtrai2 dtrai2 commented Jul 19, 2023 •
edited
Loading

closes #424
furthermore, ProcessingCriticalError aren't wrapped again inside ProcessingCriticalError and events are only cleared after they were written to the error output.

@dtrai2 dtrai2 added the bug Something isn't working label Jul 19, 2023
@dtrai2 dtrai2 requested a review from ppcad July 19, 2023 13:58
@dtrai2 dtrai2 self-assigned this Jul 19, 2023
@dtrai2 dtrai2 linked an issue Jul 19, 2023 that may be closed by this pull request
Crash on invalid JSON input in Kafka input connector #424
Closed
ppcad
ppcad approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@ppcad ppcad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ppcad ppcad merged commit 8aaadfb into main Jul 21, 2023
@dtrai2 dtrai2 mentioned this pull request Aug 8, 2023
Closed
@ekneg54 ekneg54 deleted the 424-crash-on-invalid-json-input-in-kafka-input-connector branch February 7, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppcad ppcad ppcad approved these changes

Assignees

@dtrai2 dtrai2

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on invalid JSON input in Kafka input connector
2 participants
@dtrai2 @ppcad