Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grafana and prometheus stack to quickstart #450

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Oct 6, 2023

this adds a configured grafana and prometheus stack to the quickstart setup to support further metric development and to visualize metrics for quickstart setup

@ekneg54 ekneg54 added the enhancement New feature or request label Oct 6, 2023
@ekneg54 ekneg54 self-assigned this Oct 6, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (37e2a4d) 92.28% compared to head (6d2ef2f) 92.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   92.28%   92.37%   +0.09%     
==========================================
  Files         135      135              
  Lines        9553     9553              
==========================================
+ Hits         8816     8825       +9     
+ Misses        737      728       -9     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekneg54 ekneg54 requested a review from dtrai2 October 6, 2023 13:51
@ekneg54 ekneg54 marked this pull request as ready for review October 6, 2023 13:51
Copy link
Collaborator

@dtrai2 dtrai2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change, that should surely help us develop better monitoring capabilities!

quickstart/docker-compose.yml Show resolved Hide resolved
quickstart/exampledata/config/prometheus/prometheus.yml Outdated Show resolved Hide resolved
@ekneg54 ekneg54 requested a review from dtrai2 October 9, 2023 12:07
@ekneg54 ekneg54 merged commit 0b097f7 into main Oct 9, 2023
10 checks passed
@ekneg54 ekneg54 deleted the feature-add-grafana-prometheus-stack branch October 9, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants