Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert not exists changes from #480, but keep refactorings in filter_expression #515

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

ppcad
Copy link
Collaborator

@ppcad ppcad commented Jan 29, 2024

No description provided.

@ppcad ppcad requested a review from dtrai2 January 29, 2024 13:40
@ppcad ppcad self-assigned this Jan 29, 2024
@ppcad ppcad marked this pull request as ready for review January 29, 2024 14:00
CHANGELOG.md Outdated Show resolved Hide resolved
@ppcad ppcad requested a review from dtrai2 February 1, 2024 07:00
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (bf0e41f) 92.14% compared to head (a3c900e) 91.65%.
Report is 2 commits behind head on main.

Files Patch % Lines
logprep/run_logprep.py 96.29% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   92.14%   91.65%   -0.49%     
==========================================
  Files         130      130              
  Lines        9524     9496      -28     
==========================================
- Hits         8776     8704      -72     
- Misses        748      792      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppcad ppcad merged commit 9e19caa into main Feb 1, 2024
10 checks passed
@ekneg54 ekneg54 deleted the dev-revert-not-exists-changes branch February 7, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants