export metrics via uvicorn asgi app #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekneg54
force-pushed
the
575-implement-access-logging-in-prometheus-metric-endpoint
branch
from
03af22a to
137795b
Compare
dtrai2
requested changes
Apr 26, 2024
Co-authored-by: dtrai2 <95028228+dtrai2@users.noreply.github.com>
Co-authored-by: dtrai2 <95028228+dtrai2@users.noreply.github.com>
Co-authored-by: dtrai2 <95028228+dtrai2@users.noreply.github.com>
|
@dtrai2 please have a look again and could you have a look on documentation generation? there is something wrong security best practice generation dependent. Could you fix it? |
dtrai2
requested changes
Apr 29, 2024
Co-authored-by: dtrai2 <95028228+dtrai2@users.noreply.github.com>
Co-authored-by: dtrai2 <95028228+dtrai2@users.noreply.github.com>
Co-authored-by: dtrai2 <95028228+dtrai2@users.noreply.github.com>
Co-authored-by: dtrai2 <95028228+dtrai2@users.noreply.github.com>
dtrai2
approved these changes
Apr 29, 2024
ekneg54
deleted the
575-implement-access-logging-in-prometheus-metric-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change adds the uvicorn webserver to the metrics endpoint to be able to disable server side headers, and to enable an access log. Beside this, you are now able to configure ssl transport security for the metrics endpoint.
closes #575