-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
advanced logging configuration #584
Conversation
ae503b3
to
dc3b74c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look at it and only found some minor suggestions. The first thing I noticed is though, that when running logprep with python logprep/run_logprep.py run ./quickstart/exampledata/config/pipeline.yml
I get a stacktrace telling me that the FileNotFoundError ... multiprocdir ...
. Logprep should rather tell me in a propper logmessage that the multiprocdir is missing, at least the stacktrace shouldn't be visible.
70c997a
to
1974824
Compare
Co-authored-by: dtrai2 <95028228+dtrai2@users.noreply.github.com>
Co-authored-by: dtrai2 <95028228+dtrai2@users.noreply.github.com>
this PR aims to add more flexibility to the configuration of logpreps logging facility.
it implements the python dictConfig approach described here in the python logging documentation.
As we already use custom names for our loggers I decided to leave this contrary the best practice advice to use
__name__
as the logger name. As a side effect we do not have a hierarchical order of our loggers anymore, but it gives us the flexibility to independently configure the log level of every logger in the configuration now. But I shortened the logger names in favor to get a better log output.GOALS:
TODO: