Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Support For Matrix Testing #56

Closed
fkirc opened this issue Nov 6, 2020 · 7 comments
Closed

Improve Support For Matrix Testing #56

fkirc opened this issue Nov 6, 2020 · 7 comments

Comments

@fkirc
Copy link
Owner

fkirc commented Nov 6, 2020

attranslate uses "matrix-testing" to test Ubuntu, macOS and Windows: https://github.com/fkirc/attranslate
However, supporting "matrix-testing" with skip-duplicate-actions seems to be cumbersome.
The screenshot below illustrates the problem.
The workflow is here: https://github.com/fkirc/attranslate/blob/master/.github/workflows/ci.yml
One way to fix it are skip-checks for individual workflow-steps.
This is already doable, but it requires one additional line per step.

image

@fkirc
Copy link
Owner Author

fkirc commented Nov 6, 2020

After changing the "required checks" to only "ci", the PR is mergeable again.
However, this change might yield "normal" PRs unmergeable (PRs where tests were not skipped).

image

image

@haase1020
Copy link

I am running into this issue as well - is there a fix for parallel tests?
tests

@fkirc
Copy link
Owner Author

fkirc commented Feb 3, 2021

Right now, the only workaround I am aware of is to skip individual steps (described in README).
This should be doable, but it might lead to quite a lot of boilerplate YAML-code.

@haase1020
Copy link

That is what I did, and now the pre_job is no longer working....

@fkirc
Copy link
Owner Author

fkirc commented Feb 3, 2021

If you are aiming to skip individual steps, then you might want to delete your pre_job, and instead use a regular step for skip-duplicate-actions.
But anyways, I cannot give detailed advice because there are nearly infinite ways to use skip-duplicate-actions as a pluggable component.
The README only contains two possible configurations.

@haase1020
Copy link

It's working - thank you so much!!

@akd-io
Copy link

akd-io commented Jul 30, 2021

I was facing this problem as well and was happy to find this issue! Will give the non-pre-job approach a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants