Issue, cypress parallel jobs not being marked green.

[joegaudet]

Hey, tried out your actions, set them up as expected and they seem to work great. However I'm using cypress with parallel runs to speed up testing, and as a result those required checks are not being marked as having passed.

Any thoughts?

[joegaudet]

I also see these skips here, not sure if they are working to mark the flow green as well.

[fkirc]

In my experience, GitHub accepts required checks that have been skipped.
This means that you should be able to merge the PR in your screenshot.
In other words, if your skipping-logic is doing something sane, then you can treat skipped checks as "passed" checks.

[joegaudet]

Gotcha, so it works fine for the non parallelized checks, the cypress ones won't work though, due to the fan out verify (1) verify (2) verify (3)

…

On Fri, Oct 9, 2020 at 1:52 AM Felix Kirchengast ***@***.***> wrote: In my experience, GitHub accepts required checks that have been skipped. This means that you should be able to merge the PR in your screenshot. In other words, if your skipping-logic is doing something sane, then you can treat skipped checks as "passed" checks. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#44 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA6IB56RZYLMT7DCSBJIR3SJ3FLFANCNFSM4SJMRN4A> .

[fkirc]

In general, parallelized checks shouldn't be a problem for this Action.
The newest release contains a concurrent_skipping option. If concurrent_skipping is set to false, then parallel workflows won't be skipped.

Nevertheless, the concurrent_skipping option is more about entire workflows.
If we are talking about individual jobs or steps, then it is doable to place multiple copies of skip-duplicate-actions within a single workflow.
Alternatively, a single pre_job can be used to skip multiple subsequent jobs.

[joegaudet]

This is about steps yeah, it's part of a larger workflow that generates 4 checks, they all need to report passed to github in order for the PR to go green. I'll give it a go later today :)

…

On Wed, Oct 28, 2020 at 9:16 AM Felix Kirchengast ***@***.***> wrote: In general, parallelized checks shouldn't be a problem for this Action. The newest release contains a concurrent_skipping option. If concurrent_skipping is set to false, then parallel workflows won't be skipped. Nevertheless, the concurrent_skipping option is more about entire workflows. If we are talking about individual jobs or steps, then it is doable to place multiple copies of skip-duplicate-actions within a single workflow. Alternatively, a single pre_job can be used to skip multiple subsequent jobs. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#44 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA6IBYJZQIHIU7ZU6PMRK3SNA7TLANCNFSM4SJMRN4A> .

[fkirc]

One example that might be helpful is the following workflow of GitHub docs: https://github.com/github/docs/blob/main/.github/workflows/test.yml

They have a rather complex test-setup, and they are using skip-duplicate-actions to optimize GitHub's own documentation-workflows.

[fkirc]

Perhaps this is related to my problem with "matrix testing": #56
Right now, I believe that one additional if per step is needed in order to support "matrix testing".