Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Critical] Typo in variable name due to which edge weights don't work #82

Open
virresh opened this issue Dec 31, 2018 · 2 comments
Open

[Critical] Typo in variable name due to which edge weights don't work #82

virresh opened this issue Dec 31, 2018 · 2 comments

Comments

@virresh
Copy link

virresh commented Dec 31, 2018

Line https://github.com/fkling/JSNetworkX/blob/master/src/drawing/svg.js#L266

the variable is misspelled as weigths whereas the correct code should contain weights in the switch case

I would be happy to send a PR if this project is still maintained ?
@virresh
Copy link
Author

virresh commented Dec 31, 2018

Possibly also the cause for #78

virresh added a commit to virresh/JSNetworkX that referenced this issue Dec 31, 2018
@virresh
svg.js: Fix weigths to weights
bed2384 
Also do some auxilary changes to fix undefined exceptions in
the case where string is supplied as argument

Fixes fkling#82
@virresh
Copy link
Author

virresh commented Dec 31, 2018

I've done this for the temporary fix: https://github.com/virresh/JSNetworkX/releases/tag/v0.3.4.1

There's a sample fiddle link for a working example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@virresh