Beginning of Settings Page #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -310,6 +317,8 @@ class BaseUI { | |||
| } else { | |||
| this.input_index = this.input_history.length; | |||
| } | |||
| //TODO parse irc commands here | |||
| this.client.send(hostId, serverName, text); | |||
There was a problem hiding this comment.
This looks like it will send the raw text, as well as parse the IRC command (lines 324-325). I think maybe this is a bad merge and these lines should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged with latest changes from the server branch.
Created toggle for settings.
Created initial settings page, still needs formal formatting, and connecting settings to functions.
Switch from visibility = 'hidden' to display = 'none' throughout the UI