Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parseError function #139

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

bramus
Copy link
Collaborator

@bramus bramus commented Aug 25, 2023

This parseError method is called in the CSS parser but is nowhere to be found. This PR fixes this.

The function is adapted from https://github.com/GoogleChromeLabs/container-query-polyfill/blob/faf2600f7cd7b16e500f40676dd1b144005bd186/src/engine.ts#L418, which formed the basis of the CSS Parser used in the scroll-timeline polyfill.

Copy link
Collaborator

@kevers-google kevers-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevers-google kevers-google merged commit 1e8cda4 into flackr:master Aug 28, 2023
@bramus bramus mentioned this pull request Aug 28, 2023
@bramus bramus deleted the parse-error branch September 13, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants