Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vite to build #224

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Use vite to build #224

merged 3 commits into from
Feb 3, 2024

Conversation

flackr
Copy link
Owner

@flackr flackr commented Feb 3, 2024

This is an experiment to see how vite works for #219. This PR right now only contains minimal changes to switch to vite. This fixes #188 as the build forces "use strict".

* Remove refernce to microbundle in github action
* Update expectations.
@flackr
Copy link
Owner Author

flackr commented Feb 3, 2024

This is looking pretty promising so far.

Going back to the list of goals, we should be able to:

  1. Create multiple build targets. We can either use environment variables, or different vite config files to control this.
  2. Reserved names can be specified by setting build.terserOptions to include a reserved list of names to not mangle.
  3. Typescript support is as easy as invoking tsc before vite build.
  4. I don't think auto-publishing to npm would be part of the build system. I think this would be better suited as a github action.
  5. The github build action for vite seems to be 1s to microbundle's 4s. Vite also has a magically auto-updating dev server which reloads browser windows for extra speed.
  6. As with 4, I think this is best met with github actions?

@flackr flackr requested a review from bramus February 3, 2024 19:44
@flackr
Copy link
Owner Author

flackr commented Feb 3, 2024

@bramus @johannesodland I think we should go ahead with this, and then I can make followon PR's to meet the specific goals as outlined in #224 (comment)

@flackr flackr merged commit 5543afe into master Feb 3, 2024
2 checks passed
@flackr flackr mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run automated tests in strict mode.
2 participants