Merge pull request #4 from flagbit/feature/ELSSHOP-23

fix: Add another parser for array to string
flagbit · Mar 22, 2022 · 2e33025 · 2e33025
2 parents 54d8577 + 8e04d1b
commit 2e33025
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/Command/ConfigSynchronizeCommand.php b/Command/ConfigSynchronizeCommand.php
@@ -83,11 +83,13 @@ private function executeConfigSet(array $config, string $name, ?string $salesCha
         $this->output->writeln('---------------------------------------');
         foreach ($config as $key => $value) {
             $currentValue = $this->systemConfigService->get($key, $salesChannelId);
-            $this->output->writeln(sprintf('Current value: "%s" for key: "%s"', $currentValue, $key));
+            $currentValueAsString = $this->valueToString($currentValue);
+            $valueAsString = $this->valueToString($value);
+            $this->output->writeln(sprintf('Current value: "%s" for key: "%s"', $currentValueAsString, $key));
             // using string comparison for all values (array|bool|float|int|string|null) simplified
-            if ((string) $currentValue !== (string) $value) {
+            if ($currentValueAsString !== $valueAsString) {
                 $this->systemConfigService->set($key, $value, $salesChannelId);
-                $this->output->writeln(sprintf('Changed value to: "%s" for key: "%s"', $value, $key));
+                $this->output->writeln(sprintf('Changed value to: "%s" for key: "%s"', $valueAsString, $key));
             } else {
                 $this->output->writeln(sprintf('Did not changed the value for key: "%s"', $key));
             }
@@ -133,4 +135,13 @@ private function getSalesChannels(): array
 
         return $salesChannels;
     }
+
+    private function valueToString($value): string
+    {
+        if (is_array($value)) {
+            return implode(', ', $value);
+        }
+
+        return (string) $value;
+    }
 }