Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor console commands to new AsCommand syntax #8

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

robin-homberg
Copy link
Contributor

Refs: DVELOPS6-169

@robin-homberg
Copy link
Contributor Author

robin-homberg commented Feb 21, 2024

Fix for:

[deprecation] User Deprecated: Since symfony/console 6.1: Relying on the static property "$defaultName" for setting a command name is deprecated. Add the "Symfony\Component\Console\Attribute\AsCommand" attribute to the "Flagbit\Shopware\ShopwareMaintenance\Command\PluginSynchronizeCommand" class instead.
[deprecation] User Deprecated: Since symfony/console 6.1: Relying on the static property "$defaultName" for setting a command name is deprecated. Add the "Symfony\Component\Console\Attribute\AsCommand" attribute to the "Flagbit\Shopware\ShopwareMaintenance\Command\ConfigSynchronizeCommand" class instead.

since composer.json already requires symfony/console ^6.3 here. This shouldn't be a breaking change

@mralexandernickel mralexandernickel merged commit c3f184f into main Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants